What reviewers should inspect
Reviewers should understand the purpose of the change and check correctness, security, maintainability, tests and compatibility. Review the actual diff rather than judging the change from file names alone.
Useful review comments
Good comments explain a problem, its impact and, when appropriate, a concrete alternative. Distinguish blocking issues from optional suggestions.
Authors should respond constructively
Code review is a technical discussion, not a personal evaluation. Reply to comments, make appropriate changes and explain decisions when a suggestion is not adopted.
ADVERTISEMENT